Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported SnackBar component #1551

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

tonyvugithub
Copy link
Contributor

Issue This PR Addresses

Fixed #1538

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

I have modified the SnackBar component to be written in TS. I made some changes to the component to accompany using handleClose in the close button. The onClose property is not required because it is simply prevent us to close snackbar when we clickaway. Simply remove onClose does the same thing.

For reference, you can try what I mentioned above in this playground.
https://codesandbox.io/s/material-demo-forked-qe0kl?file=/demo.js

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@chrispinkney
Copy link
Contributor

Awesome! LGTM.

firefox_2021-01-17_20-37-20

chrispinkney
chrispinkney previously approved these changes Jan 18, 2021
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one typing thing.

src/frontend/next/src/components/SnackBar/SnackBar.tsx Outdated Show resolved Hide resolved
chrispinkney
chrispinkney previously approved these changes Jan 18, 2021
humphd
humphd previously approved these changes Jan 18, 2021
src/frontend/next/src/components/SnackBar/index.ts Outdated Show resolved Hide resolved
src/frontend/next/src/components/SnackBar/SnackBar.tsx Outdated Show resolved Hide resolved
@tonyvugithub tonyvugithub deleted the next-issue1538 branch January 19, 2021 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: nextjs Nextjs related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[next] Port SnackBar to NextJS
3 participants